-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift SDK & Sample #1621
Merged
Merged
Swift SDK & Sample #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved iOS SDK from example to src
Moving the reference from the local folder iOS SDK to the newly created iOS SDK under src/swift/flwr.
Moving iOS-SDK reference
Upgrade Transport Proto to Flower 1.0
added supported platform (with version)
remove duplicate code for server.py and adapt config parameter
Content View Refactoring
Protobuf to own struct and vice versa
Add flwr proto status
tanertopal
reviewed
Mar 7, 2023
tanertopal
reviewed
Mar 7, 2023
tanertopal
reviewed
Mar 7, 2023
tanertopal
reviewed
Mar 7, 2023
tanertopal
reviewed
Mar 7, 2023
tanertopal
reviewed
Mar 7, 2023
tanertopal
reviewed
Mar 7, 2023
Merge main to fork
Merge main to fork
tanertopal
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge PR. Thank you for the great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flower Swift SDK
About
The branch implements the Flower SDK for Swift based on the initial draft
examples/ios
.Additional
It includes an iOS sample application called FLiOS with benchmarking functionality for testing the SDK.
Major Changes
examples/ios
tosrc/swift
examples/ios/server.py
has been streamlined for the sole purpose of running the FL processHow to test
Move to the folder
examples/ios
and open the fileFLiOS.xcodeproj
with XCode. Run the application FLiOS on a simulator or a physical device with iOS version 14 or higher. Execute the server/python scriptexamples/ios/server.py
. Go through the sequential steps of FLiOS and adjust the server hostname and port accordingly before starting the federated learning process. For test purposes, the standard MNIST sample is used.Remark
Github Actions for automatically running lint operations to look for possible code flaws, are not included in this PR.